Skip to content

Fix failing apt-get install in action for unit tests #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2023
Merged

Fix failing apt-get install in action for unit tests #422

merged 3 commits into from
Nov 14, 2023

Conversation

@liudmylaru
Copy link
Member

@liudmylaru liudmylaru commented Nov 13, 2023 •
edited
Loading

Description

Recently unit tests with optional dependencies started failing. Reason - system library install with apt-get on ubuntu failed with "E: Failed to fetch... 404 Not Found" errors. To fix we need to add apt update before using apt-get to install libkrb5-dev graphviz, which required for some of the unit tests with optional dependencies. This libraries can't be installed by pip or conda only.

Jira: no ticket

What was done

  • added apt update before apt-get install
  • rearranged step "Test env setup" into separate action, to avoid duplicate code
  • fixed expected value in test_opctl_conda.py::TestOpctlConda::test_conda_publish
  • removed failed test_get_service_packs_cust_tenancy() as redundant one - we already testing response, which is mocked for dev tenancy - test_get_service_packs() - link

Pre-commit

check python ast.........................................................Passed
check docstring is first.............................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
check yaml...........................................(no files to check)Skipped
detect private key.......................................................Passed
fix end of files.........................................................Passed
pretty format json...................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
black....................................................................Passed
rst ``code`` is two backticks........................(no files to check)Skipped
rst ``inline code`` next to normal text..............(no files to check)Skipped
Detect hardcoded secrets.................................................Passed
check-copyright..........................................................Passed
[fix_failing_tests_setup 0ccd1c4] Fix failing system library setup for unit tests

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 13, 2023
@liudmylaru liudmylaru changed the title Fix failing system library install in action for unit tests Fix failing apt-get install in action for unit tests Nov 13, 2023
@z7ye z7ye self-requested a review November 13, 2023 21:11
z7ye
z7ye previously approved these changes Nov 13, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 13, 2023

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

@liudmylaru liudmylaru requested a review from z7ye November 13, 2023 21:49
@github-actions
Copy link

github-actions bot commented Nov 13, 2023

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

@lu-ohai lu-ohai self-requested a review November 13, 2023 23:57
lu-ohai
lu-ohai approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@lu-ohai lu-ohai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

github-actions bot commented Nov 14, 2023

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-71.49%

@liudmylaru liudmylaru merged commit 6b75c58 into main Nov 14, 2023
@liudmylaru liudmylaru deleted the fix_failing_tests_setup branch November 14, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lu-ohai lu-ohai lu-ohai approved these changes

+2 more reviewers

@z7ye z7ye z7ye approved these changes

@mingkang111 mingkang111 mingkang111 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liudmylaru @z7ye @mingkang111 @lu-ohai